Re: [gpsd-dev] [PATCH] always install the man pages

[Mike Frysinger]

On Friday 10 February 2012 03:28:36 Bernd Zeimetz wrote:
> On 02/09/2012 11:08 PM, Mike Frysinger wrote:
> > Since we maintain local copies, don't require xmlto/xsltproc in
> > order to install them.  This makes packaging simpler.
> 
> Your patch doesn't work as manpages are removed when the build directory
> is being cleaned. If you want to implement something like that you have
> to ensure that manpages are only removed if they were built before.

my patch works perfectly fine with the release tarballs which is what i'm 
concerned with.  you're right that in the git sense, cleaning everything and 
building+installing w/out xmlto will result in an error.  i think that error 
method is fine.  attempting to maintain state locally and say "well, i just 
built the man pages and so i know i need to not clean them because i had xmlto 
installed at some point" is a bad idea.

i could have the logic only rm the man pages if manbuilder is True as that is 
less hacky.

> (On a sidenote, I still fail to understand whats so hard on installing
> the necessary tools to build them).

if i check out git and try to build that, i have no problem requiring 
xmlto/etc...  but these should not be required for people building+installing 
releases.
-mike

signature.asc
Description: This is a digitally signed message part.