|
From: | Jon Schlueter |
Subject: | Re: [gpsd-dev] A Couple of xxGSV Fixes |
Date: | Sat, 23 Apr 2016 23:11:19 -0400 |
I have three commits that fix a couple of bugs in the GSV handling (one
also affecting xxGSA), as well as fixing two affected regression cases and
adding a new one. Two of the three commits aren't email-compatible due to
the long lines in the .chk files. There are a few ways around this, but
the simplest would be for someone with commit access to fetch the commits
from my GitHub. E.g.:
MacPro:gpsd fw$ git fetch https://github.com/fhgwright/gpsd.git +code-fixes:foobar
remote: Counting objects: 16, done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 16 (delta 6), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (16/16), done.
>From https://github.com/fhgwright/gpsd
* [new branch] code-fixes -> foobar
Where "foobar" can be any local branch name of your choosing. Then the
commits are locally available, and the usual git tools can be used to
examine and/or merge them (with "git cherry-pick" replacing "git am").
The combined diff can be seen online here:
https://github.com/fhgwright/gpsd/compare/master...code-fixes
Click on any ellipsis gadget to see the full commit message.
The local branch can be deleted after merging.
BTW, I believe a couple of the offsets in nmeaid_to_prn() are incorrect.
I have no idea where the 37 for GLONASS came from, but I think it should
be 64, and I also think that the QZSS offset should be 192, not 193, since
the intent is to map *1* to 193. I left these alone for now.
Fred Wright
[Prev in Thread] | Current Thread | [Next in Thread] |