Re: [gpsd-dev] Possible Bug in libgpsd_core.c

[Gary E. Miller]

Yo Neustifter!

Interesting find.  Do you have a packet capture that shows this behavior?
Or a test procedure to force the failure?

On Mon, 21 Jan 2019 13:56:55 +0000
Neustifter Andreas <address@hidden> wrote:

> Hi all,
> 
> we have a u-blox NEO M8N chip connected via tty and used in binary
> mode. When the u-blox module loses the GPS signal and reports fix=1
> in the UBX_NAV_SOL message the gps_data.fix.mode variable is not
> updated (and stays at 3) BUT (gps_data.set & MODE_SET) still is true.
> 
> My guess is that the two lines at
> libgpsd_core.c:1461-1462<http://git.savannah.gnu.org/cgit/gpsd.git/tree/libgpsd_core.c?id=87222d0aba681b87980e7bc602cee84a5361a77e#n1461>
> are responsible for this behavior since MODE_SET is cleared here and
> the mode is thus not copied over in gps_merge_fix().
> 
> Attached a patch that attempts to fix this behavior, any thoughts on
> that?
> 
> (I'm unclear why the gps_data.set I get in the client has its
> MODE_SET bit still set but I suspect
> libgps_json.c:571<http://git.savannah.gnu.org/cgit/gpsd.git/tree/libgps_json.c?id=87222d0aba681b87980e7bc602cee84a5361a77e#n571>.)
> 
> Andreas Neustifter
> 
> 
> 
> 
> The information contained in this e-mail message is privileged and
> confidential and is for the exclusive use of the addressee. The
> person who receives this message and who is not the addressee, one of
> his employees or an agent entitled to hand it over to the addressee,
> is informed that he may not use, disclose or reproduce the contents
> thereof, and is kindly asked to notify the sender and delete the
> e-mail immediately.
> 




RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

pgpAfxxTSvGqW.pgp
Description: OpenPGP digital signature