groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 02/03: correct usage of the test utility


From: Bertrand Garrigues
Subject: [groff] 02/03: correct usage of the test utility
Date: Fri, 12 Sep 2014 22:50:36 +0000

bgarrigues pushed a commit to branch automake2
in repository groff.

commit d3c949c8fc4310a4215a42d41cf95cce8fe97b1d
Author: Ingo Schwarze <address@hidden>
Date:   Tue Sep 9 23:18:22 2014 +0200

        correct usage of the test utility
    
        According to POSIX, when called with one argument, test(1) shall
        behave as follows: Exit true (0) if $1 is not null; otherwise, exit
        false.
    
        Consequently, this behaviour is correct:
    
         $ test -n
         $ echo $?
        0
         $ test -n ""
         $ echo $?
        1
---
 configure.ac |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/configure.ac b/configure.ac
index 60de062..a60282f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -183,13 +183,13 @@ gl_LOCALCHARSET
 # src/libs/libxutil
 AM_CONDITIONAL([WITHOUT_X11], [test "x$groff_no_x" = "xyes"])
 
-AM_CONDITIONAL([BUILD_INFODOC], [test -n $make_infodoc])
-AM_CONDITIONAL([BUILD_HTML], [test -n $make_htmldoc])
-AM_CONDITIONAL([BUILD_HTMLEXAMPLES], [test -n $make_htmlexamples])
-AM_CONDITIONAL([BUILD_PDFDOC], [test -n $make_pdfdoc])
-AM_CONDITIONAL([BUILD_PDFEXAMPLES], [test -n $make_pdfexamples])
-AM_CONDITIONAL([BUILD_OTHERDOC], [test -n $make_otherdoc])
-AM_CONDITIONAL([BUILD_EXAMPLES], [test -n $make_examples])
+AM_CONDITIONAL([BUILD_INFODOC], [test -n "$make_infodoc"])
+AM_CONDITIONAL([BUILD_HTML], [test -n "$make_htmldoc"])
+AM_CONDITIONAL([BUILD_HTMLEXAMPLES], [test -n "$make_htmlexamples"])
+AM_CONDITIONAL([BUILD_PDFDOC], [test -n "$make_pdfdoc"])
+AM_CONDITIONAL([BUILD_PDFEXAMPLES], [test -n "$make_pdfexamples"])
+AM_CONDITIONAL([BUILD_OTHERDOC], [test -n "$make_otherdoc"])
+AM_CONDITIONAL([BUILD_EXAMPLES], [test -n "$make_examples"])
 
 AC_CONFIG_FILES([Makefile])
 AC_OUTPUT



reply via email to

[Prev in Thread] Current Thread [Next in Thread]