[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[groff] 02/02: m4/groff.m4: Revert paranoid shell assignments.
From: |
G. Branden Robinson |
Subject: |
[groff] 02/02: m4/groff.m4: Revert paranoid shell assignments. |
Date: |
Mon, 12 Nov 2018 16:54:55 -0500 (EST) |
gbranden pushed a commit to branch master
in repository groff.
commit cc6d4067c18c3c58e6173f972a1f3d899598f7a0
Author: G. Branden Robinson <address@hidden>
Date: Mon Nov 12 16:41:08 2018 -0500
m4/groff.m4: Revert paranoid shell assignments.
My quotations of variable test(1) arguments were fine, but the
ones to variable assignments were unnecessary. Since, per the
Autoconf manual, quoting RHS variables in assignments is
actually _less_ portable, revert them. (The way I'll think
about this is going forward is "word splitting occurs before
parameter expansion".) Thanks to Colin Watson for the tip!
See:
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Shell-Substitutions.html
Signed-off-by: G. Branden Robinson <address@hidden>
---
m4/groff.m4 | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/m4/groff.m4 b/m4/groff.m4
index 4f08cb9..cc2ef32 100644
--- a/m4/groff.m4
+++ b/m4/groff.m4
@@ -776,7 +776,7 @@ AC_DEFUN([GROFF_BROKEN_SPOOLER_FLAGS],
AC_DEFUN([GROFF_PAGE],
[AC_MSG_CHECKING([default paper size])
- groff_prefix="$prefix"
+ groff_prefix=$prefix
test "x$prefix" = "xNONE" && groff_prefix=$ac_default_prefix
if test -z "$PAGE" && test -r /etc/papersize; then
PAGE=`cat /etc/papersize`
@@ -784,13 +784,13 @@ AC_DEFUN([GROFF_PAGE],
if test -z "$PAGE"; then
descfile=
if test -r "$groff_prefix"/share/groff/font/devps/DESC; then
- descfile="$groff_prefix"/share/groff/font/devps/DESC
+ descfile=$groff_prefix/share/groff/font/devps/DESC
elif test -r "$groff_prefix"/lib/groff/font/devps/DESC; then
- descfile="$groff_prefix"/lib/groff/font/devps/DESC
+ descfile=$groff_prefix/lib/groff/font/devps/DESC
else
for f in "$groff_prefix"/share/groff/*/font/devps/DESC; do
if test -r "$f"; then
- descfile="$f"
+ descfile=$f
break
fi
done
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [groff] 02/02: m4/groff.m4: Revert paranoid shell assignments.,
G. Branden Robinson <=