Re: [Groff] Bug? with color

[Rick Richardson]

On Sat, Jan 05, 2002 at 08:21:12AM -0600, Rick Richardson wrote:
> On Sat, Jan 05, 2002 at 10:27:18AM +0000, Gaius Mulley wrote:
> > 
> > Hi Rick,
> > 
> > > Which color bug is it supposed to fix?  I think I found and reported 4
> > > different color bugs.
> > 
> > I believe it fixes the first one you reported (with colbox example).
> > Can you verify this fix? I wonder whether you could possibly check if all
> > three of the other bugs still exist (and possibly email example troff
> > code to highlight the problem)?
> 
> Yes, it fixes the first bug.  But it doesn't fix one or more of the others.
> 
> I'm preparing a care package of examples right now.  But my kid
> wants me to play Pikmin. :-)

Attachment 1:  colbug2.1
        Switches from CYAN to RED and RED to BLUE one character too late

Attachment 2:  colbug3.1
        Same prob as above, *PLUS* fails to set BLACK background on
        first color bar.

Do a diff colbug2.1 colbug3.1 to see the very minor difference in
the source code.

Also, for reference, here is my hack fix that fixes colbug2.1, but
not colbug3.1....

$ diff -u ps.cc ps.cc.rick
--- ps.cc       Sat Jan  5 08:13:51 2002
+++ ps.cc.rick  Mon Dec 31 14:48:51 2001
@@ -599,7 +599,7 @@
     if (sbuf_len < SBUF_SIZE
        && sty == sbuf_style
        && sbuf_vpos == env->vpos
-       && sbuf_color->is_equal(env->col)) {
+       && sbuf_color->is_equal(env->col)&&0) {
       if (sbuf_end_hpos == env->hpos) {
        sbuf[sbuf_len++] = code;
        sbuf_end_hpos += w + sbuf_kern;
@@ -826,7 +826,7 @@
     set_style(sbuf_style);
     output_style = sbuf_style;
   }
-  if (!output_color->is_equal(sbuf_color))
+  if (1||!output_color->is_equal(sbuf_color))
     set_color(sbuf_color);
   int extra_space = 0;
   if (output_hpos < 0 || output_vpos < 0)
@@ -916,7 +916,7 @@
       output_draw_point_size = -1;
     }
   }
-  if (!env->col->is_equal(output_color))
+  if (1||!env->col->is_equal(output_color))
     set_color(env->col);
 }
 
@@ -932,7 +932,7 @@
         .put_symbol("FL");
   }
   else {
-    if (output_color->is_equal(fill_color))
+    if (0&&output_color->is_equal(fill_color))
       out.put_symbol("fill");
     else {
       set_color(fill_color, 0);


-- 
Rick Richardson  address@hidden        http://home.mn.rr.com/richardsons/
Stock information at your fingertips:   http://linuxtrade.0catch.com/

If you write code that needs comments at the end of a line,
your code is crap. -- Linus Torvalds

colbug2.1
Description: Text document

colbug3.1
Description: Text document