Re: [groff] Recent contrib/hdtbl changes may have broken it

[G. Branden Robinson]

At 2018-10-27T03:02:59+0000, Bjarni Ingi Gislason wrote:
> On Fri, Oct 26, 2018 at 04:28:02PM -0400, G. Branden Robinson wrote:
> > Hi all,
> > 
> > 
> [...]
> >   GROFF    contrib/hdtbl/examples/color_nested_tables.ps
> > ../contrib/hdtbl/examples/color_nested_tables.roff:40: The 1st width value 
> > () is too small. It should be greater than 12000.
> > ../contrib/hdtbl/examples/color_nested_tables.roff:52: The 1st width value 
> > () is too small. It should be greater than 11999.
> 
>   I got those too.  I avoided the warnings by using "0.999n" instead of
> "1n" in one of the arguments of "TBL".  The cause is thus most probably
> a rounding error, so a better solution is to apply a correction where
> the rounding error occurs.

These warnings appear to be caused by:

commit 305701e856baa0b23066279160eaeb38bd27b9e4
Author: Ingo Schwarze <address@hidden>
Date:   Thu Aug 9 22:50:47 2018 +0200

    contrib/hdtbl: do forgotten renamings .pv -> .t*pv

    This was forgotten in commit 6fb4a0ab on Feb 8, 2010.
    Fixing it improves the formatting of all hdtbl examples.
    Reported by Bjarni Ingi Gislason in http://savannah.gnu.org/bugs/?54470.

    While here, also fix a typo in short_reference.roff.

If I revert it, these warnings go away.

>   There is still a fix (explanation) missing for the empty parentheses
> in the warnings.
> 
> [...]
> > troff: contrib/hdtbl/examples/fonts_n.roff:141: .pso request not allowed in 
> > safer mode
> > troff: contrib/hdtbl/examples/fonts_n.roff:141: name expected (got '\{')
> > fonts_n.roff: listing font ''...
> > troff: contrib/hdtbl/examples/fonts_n.roff:141: warning: can't find font '='
> > troff: contrib/hdtbl/examples/fonts_n.roff:141: .pso request not allowed in 
> > safer mode
> >   GROFF    contrib/hdtbl/examples/fonts_x.ps
> > troff: contrib/hdtbl/examples/fonts_x.roff:152: .pso request not allowed in 
> > safer mode
> > troff: contrib/hdtbl/examples/fonts_x.roff:152: name expected (got '\{')
> > fonts_x.roff: listing font ''...
> > troff: contrib/hdtbl/examples/fonts_x.roff:152: warning: can't find font '='
> > troff: contrib/hdtbl/examples/fonts_x.roff:152: .pso request not allowed in 
> > safer mode
> >   GROFF    contrib/hdtbl/examples/mixed_pickles.ps
> 
> I avoided the ".pso" warning by adding "-U" to the HDTBL_PFLAG.

Yes; as I noted at the beginning of the thread, we're stuck with .psos
in hdtbl's examples until some refactoring is undertaken.

> Then I did not get the other warnings, but the "fonts_n.ps" file does
> not show any font, while "fonts_x.ps" contains all of them (38).
> 
>   An older "fonts_n.ps" file shows only the first font.

Depending on what you mean by "older", I can't reproduce that; if I
revert all 3 of Ingo's hdtbl commits from August, all of the examples
look good on my machine.

git checkout 7b3fa85e0f2da11f9475d2a36bb1a9608a6a999f

is a quick-and-dirty way to confirm this.  (I would do that in a dummy
checkout; thanks to the gnulib submodule, it's mildly irritating to get
the tree back out of "detached HEAD" state.)

-- 
Regards,
Branden

signature.asc
Description: PGP signature