[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] sun partition map support

From: Marco Gerards
Subject: Re: [PATCH] sun partition map support
Date: Mon, 07 Feb 2005 21:46:44 +0000
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

Vincent Pelletier <address@hidden> writes:

> Here is the second version, with changes requested by Marco.

Great!  Thanks! :)

This patch will be committed on Friday, if I don't hear anything
before then.

> 2005-02-07  Vincent Pelletier  <address@hidden>
> ~    * partmap/sun.c: File added.
> ~    * conf/i386-pc.rmk: References to partmap/sun.c added.
> ~      include/grub/partition.h, util/grub-emu.c: Likewise.

It's not clear where it got added from this.  I'll fix this when
committing the patch.

> References to sun partition map may also have to be added to apple rmk
> file, but as I can't test it I didn't.

Sure, I'll do that.

In the code you had:

+  p = (struct grub_partition *) grub_malloc (sizeof (struct grub_partition));
+  if (p)
+    {

That indents a huge block of code.  I will change that to:

+  p = (struct grub_partition *) grub_malloc (sizeof (struct grub_partition));
+  if (!p)
+    return grub_errno;

Please send patches using the content-type text/x-patch.  You send it
as audio/x-mp3 so it started some audio player here when I tried
viewing it. :-/


reply via email to

[Prev in Thread] Current Thread [Next in Thread]