[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: consolidate ELF header checks

From: Yoshinori K. Okuji
Subject: Re: consolidate ELF header checks
Date: Fri, 11 Feb 2005 19:07:06 +0100
User-agent: KMail/1.7.1

On Friday 11 February 2005 18:25, Marco Gerards wrote:
> I assume that means I can commit the patch.  I'll do that on Sunday
> evening.  Just tell me if there are still problems and I will wait
> with committing the patch.

One minor problem in his patch is this part:

@@ -497,12 +520,25 @@ grub_dl_load_core (void *addr, grub_size
   grub_dl_t mod;
   e = addr;
-  if (! grub_arch_dl_check_header (e, size))
+  if (grub_dl_check_header (e, size))
       grub_error (GRUB_ERR_BAD_MODULE, "invalid ELF header");
       return 0;
As grub_dl_check_header is supposed to provide a more detailed error, 
grub_dl_load_core should not set a new error here.

Once this is fixed, I have no objection.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]