grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] printf long format


From: Marco Gerards
Subject: Re: [patch] printf long format
Date: Wed, 22 Jun 2005 18:24:51 +0200
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux)

"Yoshinori K. Okuji" <address@hidden> writes:

> On Wednesday 22 June 2005 16:33, Hollis Blanchard wrote:
>> You have made this comment a few times now. Please understand: I do
>> watch out for this stuff, apparently more carefully than other
>> committers. I am removing whitespace from an otherwise blank line.
>>
>> I am not saying I will never accidentally check in errant whitespace,
>> but you can see that this is a correction, not an accident.
>
> Why does Marco complain about this? Because of the readability of a patch? In 
> this case, the option --ignore-space-change to diff would help you...

Readability.  Hollis prefers no whitespace on a line.  I do not care
about these spaces, but it is too much noise to either add or remove
it.

With --ignore-space-change you sometimes miss changes that were made
on purpose.

--
Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]