[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Kernel support for VESA Bios Extension
From: |
Marco Gerards |
Subject: |
Re: [PATCH] Kernel support for VESA Bios Extension |
Date: |
Thu, 14 Jul 2005 21:02:13 +0200 |
User-agent: |
Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) |
Vesa Jääskeläinen <address@hidden> writes:
Hi,
Thanks a lot for your work. I am looking forwards to the VESA
console!
> Here is attached a patch that adds VBE support to kernel and include
> file to make it easier to use it. There is diff for both i386-pc.rmk
> and i386-pc.mk. Latter could be removed and let build process to
> generate it again, but I think that .mk file is present in CVS so I
> left both there.
Please always include the changed to *.rmk in the patches. You don't
have to supply *.mk because those files are generated and make the
patch just harder to read.
> I will make separate patch for the frame buffer console after this is
> first committed. (And I need to make some cleanups there first)
Ok.
> I would like to hear comments about the patch. I tried to implement
> most commonly needed functions, so you can't do everything with
> this. As I didn't need to use every function in my frame buffer
> console test, some things might not work. But I tried to make my best
> to proof read every function.
Can you please make sure you are using the GCS for coding style?
Please have a look at the other sourcecode and the GCS (GNU Coding
Standards) first:
http://www.gnu.org/prep/standards/
It is important for us to have a single and consistent coding style.
If you have questions about either GRUB or the coding style you are of
course free to ask.
Thanks,
Marco
- [PATCH] Kernel support for VESA Bios Extension, Vesa Jääskeläinen, 2005/07/14
- Re: [PATCH] Kernel support for VESA Bios Extension,
Marco Gerards <=
- Re: [PATCH] Kernel support for VESA Bios Extension, Vesa Jääskeläinen, 2005/07/14
- Re: [PATCH] Kernel support for VESA Bios Extension, Marco Gerards, 2005/07/14
- Re: [PATCH] Kernel support for VESA Bios Extension, Yoshinori K. Okuji, 2005/07/15
- Re: [PATCH] Kernel support for VESA Bios Extension, Vesa Jääskeläinen, 2005/07/15
- Re: [PATCH] Kernel support for VESA Bios Extension, Yoshinori K. Okuji, 2005/07/15
- Re: [PATCH] Kernel support for VESA Bios Extension, Marco Gerards, 2005/07/16