Re: [PATCH] generic ELF loading #3

[Johan Rydberg]

Hollis Blanchard <address@hidden> writes:

> --- grub2-cvs.orig/include/grub/types.h       2006-10-31 19:06:47.000000000 
> -0600
> +++ grub2-cvs/include/grub/types.h    2006-10-31 19:06:58.000000000 -0600
> @@ -23,6 +23,8 @@
>  #include <config.h>
>  #include <grub/cpu/types.h>
>  
> +#define __unused __attribute__ ((unused))
> +

First when I saw this it made me wanna comment on it, and tell you
that defines should all be in uppercase.  But then I poked through the
code, and saw the usage of it, and it looked quite nice, with the
exception of the __-prefix.  There are a lot of "common" words that
are keywords in C; inline, const and auto for example.  Maybe we
should make "unused" a reserved keyword in GRUB?  That would allow
us to write code like;

  int
  grub_foo (int x, unused int foo)
  {
    ...
  }

Just a thought.  Otherwise your patch looked just fine Hollis.

~j

pgpFetL37NQ6A.pgp
Description: PGP signature