[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: update-grub2 patch

From: Yoshinori K. Okuji
Subject: Re: update-grub2 patch
Date: Sat, 21 Apr 2007 15:38:38 +0200
User-agent: KMail/1.8.2

On Tuesday 17 April 2007 14:49, Robert Millan wrote:
> Here's my patch.  Let me know if it's ok for commit.

To include this in the official repository, you need to take care about the 
portability. You should not rely on the existence of some programs.

For instance, you use bash. This is not good. Use /bin/sh instead. You use 
shopt. This is not good, because this is specific to bash. The way in which 
you write test expressions is not very portable.

Also, don't use negations (i.e. `!'), because they don't behave correctly on 
some platforms. Use "if ... then else ..." instead.

For more information, please look at the chapter "Portable Shell Programming" 
in the Autoconf manual.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]