[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: update-grub2 patch
From: |
Yoshinori K. Okuji |
Subject: |
Re: update-grub2 patch |
Date: |
Thu, 3 May 2007 23:44:14 +0200 |
User-agent: |
KMail/1.8.2 |
On Thursday 03 May 2007 17:48, Robert Millan wrote:
> On Wed, May 02, 2007 at 03:31:16PM +0200, Robert Millan wrote:
> > > You should avoid ! in test. Use else instead.
> >
> > Earlier when I read the portability document I was pointed to, I found:
> >
> > "You may use `!' with `test', but not with `if'"
> >
> > Are you sure this change is required?
>
> Well, since this is just one line, I fixed it.
>
> Attached new patch fixes all three problems ('which', 'test !' and 'test
> -z|-n') and also adds code in 00_header.in to enable gfxterm when the
> unicode font is found in /boot/grub.
>
> Let me know if everything is ok now..
OK. Please go ahead.
Thanks,
Okuji