[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] jpeg image reader
From: |
Marco Gerards |
Subject: |
Re: [PATCH] jpeg image reader |
Date: |
Tue, 15 Jan 2008 15:27:11 +0100 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
Bean <address@hidden> writes:
[...]
>> > for (i = 0; i < cc; i++)
>> > {
>> > int id, ss;
>> >
>> > id = grub_jpeg_get_byte (data) - 1;
>> > if ((id < 0) || (id >= 3))
>> > return grub_error (GRUB_ERR_BAD_FILE_TYPE, "jpeg: invalid index");
>> >
>> > ss = grub_jpeg_get_byte (data); /* sampling factor */
>> > if (!id)
>> > {
>> > data->vs = ss & 0xF; /* vertical sampling */
>> > data->hs = ss >> 4; /* horizontal sampling */
>>
>> Please use correct interpunction.
>
> I'm sorry, what do you mean by correct interpunction ?
That I prefer:
/* vertical sampling */ -> /* Vertical sampling. */
Same for the other two lines. With this change, only the legal
question remains.
--
Marco
- Re: [PATCH] jpeg image reader, (continued)
- Re: [PATCH] jpeg image reader, Marco Gerards, 2008/01/13
- Re: [PATCH] jpeg image reader, Bean, 2008/01/14
- Re: [PATCH] jpeg image reader, Marco Gerards, 2008/01/15
- Re: [PATCH] jpeg image reader, Robert Millan, 2008/01/15
- Re: [PATCH] jpeg image reader, Marco Gerards, 2008/01/15
- Re: [PATCH] jpeg image reader, Robert Millan, 2008/01/15
- Re: [PATCH] jpeg image reader, Marco Gerards, 2008/01/15
- Re: [PATCH] jpeg image reader, Bean, 2008/01/15
- Re: [PATCH] jpeg image reader, Marco Gerards, 2008/01/15
- Re: [PATCH] jpeg image reader, Bean, 2008/01/15
- Re: [PATCH] jpeg image reader,
Marco Gerards <=
- Re: [PATCH] jpeg image reader, Bean, 2008/01/15
- Re: [PATCH] jpeg image reader, Marco Gerards, 2008/01/15
- Re: [PATCH] jpeg image reader, Bean, 2008/01/15
- Re: [PATCH] jpeg image reader, Bean, 2008/01/15
- Re: [PATCH] jpeg image reader, Marco Gerards, 2008/01/21
- Re: [PATCH] jpeg image reader, Bean, 2008/01/22