[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] btree support in xfs driver
From: |
Robert Millan |
Subject: |
Re: [PATCH] btree support in xfs driver |
Date: |
Thu, 31 Jan 2008 20:58:47 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Fri, Feb 01, 2008 at 03:40:20AM +0800, Bean wrote:
> Hi,
>
> I add btree support for the xfs driver, and fix a few bugs. Now i' m
> able to list a directory of over 5000 files, please test it.
You're truly impressive...
One comment:
> {
> struct grub_fshelp_node *diro = (struct grub_fshelp_node *) dir;
> - auto int call_hook (grub_uint64_t ino, char *filename);
> + auto int __attribute__ ((regparm(1))) call_hook (grub_uint64_t ino,
> char *filename);
>
> - int call_hook (grub_uint64_t ino, char *filename)
> + int __attribute__ ((regparm(1))) call_hook (grub_uint64_t ino, char
> *filename)
would this break on non-i386 ?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)