grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] to make grub2 compile on NetBSD


From: walt
Subject: Re: [PATCH] to make grub2 compile on NetBSD
Date: Mon, 04 Feb 2008 14:55:34 -0800
User-agent: Thunderbird 3.0a1pre (X11/2008020404)

Robert Millan wrote:
walt<address@hidden>  writes:

NetBSD's gcc wants libgcc and libc to define __enable_execute_stack,
but this is useless for a free-standing executable like grub.  Define
a dummy function in lieu of libgcc to supply __enable_execute_stack.

Second try:

        Make NetBSD's gcc happy.

        * kern/mm.c: New dummy symbol __enable_execute_stack.
        (include/grub/mm.h): Likewise.

This ChangeLog entry seems wrong.  I'll write it up for you, as it's easier to
explain with an example:

        Make NetBSD's gcc happy.

        * include/grub/mm.h
        [__NetBSD__] (__enable_execute_stack): New function prototype.
        * kern/mm.c
        [__NetBSD__] (__enable_execute_stack): New function.

Okay, thanks.  Does the [__NetBSD__] token denote an #ifdef?  How
would I indicate a patch for, say, Net/Free/Dragonfly BSD's at the
same time?

Oh, and should you mention that the new function does nothing?

Marco:  I didn't add the header for the changelog because I don't
know who (if anyone) is going to commit it.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]