[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug#461442: detection of other OSes in update-grub

From: Robert Millan
Subject: Re: Bug#461442: detection of other OSes in update-grub
Date: Wed, 6 Feb 2008 13:02:04 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Wed, Feb 06, 2008 at 11:12:44AM +0100, Fabian Greffrath wrote:
> I do not believe this is an overkill. Do you want grub-probe to print 
> "i-dont-check-my-arguments" (grub-probe --target=device --device 
> i-dont-check-my-arguments) ?
> Even worse, if you select another target than 'device' and if you don't 
> check if the given parameter is *really* a device name, you will pass 
> the faulty parameter over to the other functions that are called in 
> probe () and fail with some "cannot stat ..." message . In my opinion 
> this should not happen. Instead, grub-probe should fail gracefully with 
> a dedicated error messge in this situation as proposed by my patch.

Ok, I don't mind that much.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]