[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cdrom access patch

From: Pavel Roskin
Subject: Re: [PATCH] cdrom access patch
Date: Mon, 17 Mar 2008 00:31:03 -0400

On Sat, 2008-03-15 at 15:34 +0800, Bean wrote:

> Ok, the new patch add (cd0) alias for cdrom device, the corresponding
> (hdN) is also present.
>       (grub_biosdisk_call_hook): Only handle (hdN) device name.

I still don't understand this part.  Maybe you could split your patch
into smaller parts?

Suppose we hard drives at 0x80 and 0x82 and a CD at 0x90.  We can call
grub_biosdisk_get_cdinfo_int13_extension() and figure out that 0x90 is
the boot CD, so we call it (cd0).  Then we go through the drives and
call them (hd0), (hd1).

If it's OK to have an alias, why not suppress of hide the original name?

At what point do we need to use the _name_ to calculate the BIOS number?
Why cannot we simply store that number into some field?

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]