[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New x86_64 EFI patch
From: |
Pavel Roskin |
Subject: |
Re: [PATCH] New x86_64 EFI patch |
Date: |
Thu, 17 Jul 2008 12:17:30 -0400 |
On Thu, 2008-07-17 at 18:01 +0200, Javier Martín wrote:
> I think this one would be better, as it follows the structure what's
> done with i386: vendor=apple -> efi; anything_else -> pc.
That's a good call. I'm working on a more radical patch now. I'll post
it for review.
> Also, this one
> errors out with a more understandable message that does not conflict
> with another check some lines down.
I agree that the messages should be improved.
> Index: configure.ac
> ===================================================================
> --- configure.ac (revisión: 1714)
> +++ configure.ac (copia de trabajo)
> @@ -59,11 +59,11 @@
> # Guess the platform if not specified.
> if test "x$with_platform" = x; then
> case "$target_cpu"-"$target_vendor" in
> - i386-apple) platform=efi ;;
> - i386-*) platform=pc ;;
> + i386-apple|x86_64-apple) platform=efi ;;
> + i386-*|x86_64-*) platform=pc ;;
> powerpc-*) platform=ieee1275 ;;
> sparc64-*) platform=ieee1275 ;;
> - *) AC_MSG_ERROR([unsupported machine type]) ;;
> + *) AC_MSG_ERROR([unable to guess platform. Use --with-platform]) ;;
That's misleading. We can guess platform for any supported CPU (well,
we try out best). The real problem is that the CPU is not supported,
and that's what the message should say.
--
Regards,
Pavel Roskin
- Re: [PATCH] New x86_64 EFI patch, (continued)
- Re: [PATCH] New x86_64 EFI patch, Bean, 2008/07/12
- Re: [PATCH] New x86_64 EFI patch, Bean, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch, Javier Martín, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch, Bean, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch, Pavel Roskin, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch, Pavel Roskin, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch, Bean, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch, Javier Martín, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch, Bean, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch, Javier Martín, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch,
Pavel Roskin <=
- Re: [PATCH] New x86_64 EFI patch, Pavel Roskin, 2008/07/17
- Re: [PATCH] New x86_64 EFI patch, Javier Martín, 2008/07/17
- generic BIOS-less boot (Re: [PATCH] New x86_64 EFI patch), Robert Millan, 2008/07/19
- Re: [PATCH] New x86_64 EFI patch, Robert Millan, 2008/07/12
- Re: [PATCH] New x86_64 EFI patch, Bean, 2008/07/12
- Re: [PATCH] New x86_64 EFI patch, Bean, 2008/07/12