[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] update-grub for Cygwin

From: Robert Millan
Subject: Re: [PATCH] update-grub for Cygwin
Date: Fri, 25 Jul 2008 22:42:22 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Thu, Jul 24, 2008 at 10:39:04PM +0200, Christian Franke wrote:
> +
> +d="`${grub_probe} -t drive "$p" 2>/dev/null`" || exit 0

Please avoid reliing on '-t drive'.  It's based on which just
contains guesswork.

prepare_grub_to_access_device() is a much better option.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]