Re: [PATCH] skip over invalid BSD partitions

[Marco Gerards]

Robert Millan <address@hidden> writes:

> On Fri, Aug 01, 2008 at 12:40:17PM +0200, Marco Gerards wrote:
>> > -              return grub_error (GRUB_ERR_BAD_PART_TABLE,
>> > -                                 "no space for disk label");
>> > -
>> > +              {
>> > +                grub_error (GRUB_ERR_BAD_PART_TABLE,
>> > +                            "no space for disk label");
>> > +                continue;
>> > +              }
>> 
>> If you continue as no error occured, why do you throw an error?
>
> Uhm nobody's going to handle this error.  The caller will simply see that
> some partitions are not processed.
>
> How about using grub_dprintf instead?

Agreed.

--
Marco