grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Home-End keys in menu


From: Carles Pina i Estany
Subject: Re: [PATCH] Home-End keys in menu
Date: Wed, 6 Aug 2008 20:31:32 +0200
User-agent: Mutt/1.5.18 (2008-05-17)


Hello,

On Aug/05/2008, Marco Gerards wrote:

> > Some weeks ago I sent a patch that didn't have any discussion. I'm
> > sending it again, maybe everybody was in holidays :-)
> >
> > Actually I updated the patch (added some spaces to comply with the
> > coding style).
> >
> > * menu/normal.c: Add Home and End keys in grub-menu
> 
> The first line of the changelog entry is missing (name + e-mail
> address).  Please mention the function you change like:

done! (see below)

[...]

> The indentation of the case statement doesn't seem right...

[...]

> This indentation also looks funny...

was not right (not a problem, it's fixed now).

Also, the indentation got worst in the mail :-)

Changelog:
-------
2008-08-06  Carles Pina i Estany  <address@hidden>

        * menu/normal.c (run_menu): Add Home and End keys in grub-menu.
-------

Patch is attached.

Thank you,

-- 
Carles Pina i Estany            GPG id: 0x17756391
        http://pinux.info

Attachment: home_end3.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]