[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] decouple mmap parsing by using grub_available_iterate()

From: Robert Millan
Subject: Re: [PATCH] decouple mmap parsing by using grub_available_iterate()
Date: Mon, 11 Aug 2008 23:24:18 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Mon, Aug 11, 2008 at 06:39:17PM +0300, Vesa Jääskeläinen wrote:
> Robert Millan wrote:
> >Hi,
> >
> >This patch decouples memory map parsing into a separate 
> >grub_available_iterate()
> >function, for i386-pc and i386-coreboot.  It is mostly intended as a 
> >cleanup.
> >Makes the code more modular so that, for example, the multiboot loader can
> >construct a memory map without having specific knowledge of the platform,
> >allows to recombine various init.c & mmap.c in different ways, etc.
> Why not use grub_mmap prefix ?

You mean like grub_mmap_iterate ?  Seems fine (since the change is trivial,
I'll skip sending a new patch).

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]