grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Idea: use menu hook to implement the savedefault command


From: Robert Millan
Subject: Re: Idea: use menu hook to implement the savedefault command
Date: Tue, 12 Aug 2008 10:52:13 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Aug 12, 2008 at 09:27:42AM +0800, Bean wrote:
> On Tue, Aug 12, 2008 at 5:32 AM, Robert Millan <address@hidden> wrote:
> > On Tue, Aug 12, 2008 at 05:03:10AM +0800, Bean wrote:
> >> Hi,
> >>
> >> Now it's possible to implement savedefault with load_env and save_env,
> >> but the problem is we need to add it to every menuitem, it's tedious
> >> process, and new item don't get it automatically.
> >
> > After discussing this on IRC, I just thought of another alternative.  We
> > could add a pair of functions to update-grub_lib, like:
> >
> > begin_menuentry ()
> > {
> >  title=$1
> >  echo "menuentry \"$title\" {"
> >  echo "do some env-edit magic"
> > }
> >
> > end_menuentry ()
> > {
> >  echo "}"
> > }
> >
> > then have each of the /etc/grub.d modules that add menuentries use these
> > functions instead of creating the menuentry directly.
> >
> > As a side-effect benefit, the /etc/grub.d modules become a bit more
> > readable.
> 
> Hi,
> 
> Oh right, if you can do it in update-grub, it's probably better to do
> it there.

Ok, I'll see about that.

> The above post also contain some idea about the
> implementation of password command, perhaps I post a seperate post for
> it.

Notice there's already an implementation of a lock command:

  http://www.mail-archive.com/address@hidden/msg05350.html

which, I think, even without password it would satisfy most of the users who
want lock/password.  I recommend you read that thread before venturing into
implement it (Okuji didn't like my initial proposal, and I run out of time
to find/implement another approach).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]