grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes


From: Robert Millan
Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes
Date: Wed, 13 Aug 2008 00:40:41 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
> >           [GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...) instead 
> > of   
> >           grub_printf.
> 
> Why?
> 
> It would be better to make a util/misc.c:grub_print_error instead of this

Problem is that kern/err.c is already included in grub-probe.  So then we would
have to add util/misc.c:grub_print_error _and_ disable grub_print_error.

> Please use -up for diff, you can use:
> $ svn diff --diff-cmd diff -x -up

Thanks for the tip, I've been looking for this ;-)

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]