[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] New command checktime

From: Bean
Subject: Re: [PATCH] New command checktime
Date: Wed, 13 Aug 2008 09:46:15 +0800

On Wed, Aug 13, 2008 at 5:49 AM, Marco Gerards <address@hidden> wrote:
> Bean <address@hidden> writes:
>> On Tue, Aug 12, 2008 at 5:07 AM, Marco Gerards <address@hidden> wrote:
>>>>       * commands/date.c: New file.
>>>>       * commands/datetime.c: Likewise.
>>> This is not a command.  But I do not really know a good place for this
>>> module...
>> How about the /hook directory ?
> Perhaps?  Do you have suggestions what we can place there, besides
> this?
> Otherwise the patch looks fine to me :-)


Oh, please take a look at my other post "Idea: implementation of the
password command",  it sugguest to implement password with hooks, for
example, reading $GET_PASSWORD would prompt the user for password and
return the encrypted form.

BTW, I'm thinking perhaps it's better to move the hook function from
datetime.mod to datehook.mod, and datetime.mod only contain
grub_get_datetime, grub_set_datetime, grub_get_weekday and
grub_get_weekday_name. Module like date.mod only need the datetime
functions, it's a little wired to install the hook as a side effect.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]