grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] try2, Enable grub_cpu_idle for i386/pc to halt the CPU


From: Colin D Bennett
Subject: Re: [PATCH] try2, Enable grub_cpu_idle for i386/pc to halt the CPU
Date: Sat, 16 Aug 2008 06:22:57 -0700

On Thu, 14 Aug 2008 22:27:07 -0500
David Fries <address@hidden> wrote:

> On Wed, Aug 13, 2008 at 11:34:22AM +0200, Marco Gerards wrote:
> > Please do not add .mk changes in a patch, it is a generated file :-)
> 
> What's a generated file doing in the repository if people aren't
> supposed to send in diffs against it?

I've brought up this issue a couple of times.  I think this particular
generated file is the worst because it is modified very often, unlike,
for instance, the 'configure' script which is more rarely modified.
Therefore since the *.rmk files are often modified (and thus the *.mk
files also), we have to deal with this a lot.

I guess it may seem like a minor issue to many, but all those minor
issues add up to occasional headaches.  My solution is to base my
personal bzr branches (I use the Bazaar distributed VCS for my work,
so I can have my own branches locally) off of a cleaned up version of
svn trunk where the *.mk files are deleted.

Anyway, if you want to read what Okuji and others have said about
removing the conf/*.mk files in the past, check out this in the
archives:
<http://thread.gmane.org/gmane.comp.boot-loaders.grub.devel/7312/focus=7324>

Regards,
Colin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]