Re: [PATCH] Split of raid scan code

[Robert Millan]

On Sat, Aug 16, 2008 at 11:20:04PM +0800, Bean wrote:
> On Sat, Aug 16, 2008 at 8:16 PM, Robert Millan <address@hidden> wrote:
> > On Sat, Aug 16, 2008 at 05:07:00PM +0800, Bean wrote:
> >> Hi,
> >>
> >> This new patch seperates raid5 and raid6 recover code from raid.c, and
> >> place them in module raid5rec.mod and raid6rec.mod. The recover code
> >> is only needed when some of the disk are missing or corrupted, which
> >> is not common. But raid.c is installed to mbr, so size is important.
> >> If there is enough room in mbr for the extra module, they can use
> >> --modules option in grub-install to add these modules.
> >
> > I find this scary in the sense that users need to know about these modules
> > to get the benefit of recovery, and even then, they also need to know they
> > are affected by this problem when they install GRUB (since otherwise they
> > won't be able to bootstrap).
> >
> > Is it possible to detect whether recover code will be needed when 
> > grub-install
> > is run, and then either add the extra modules or abort with an error?
> 
> Hi,
> 
> grub-probe don't use the recover module, so if it have problem at
> install time, user would know about it (error message would be
> "raid5rec not loaded").

Sounds fine to me.  But the error message is too cryptic IMHO.  Consider the
situation in which user was running grub-install and sees this error.
Shouldn't we tell her to fix the RAID instead?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."