[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] FAT, UFS and mtime

From: Bean
Subject: Re: [PATCH] FAT, UFS and mtime
Date: Mon, 2 Mar 2009 03:13:58 +0800

On Mon, Mar 2, 2009 at 12:25 AM, phcoder <address@hidden> wrote:
> Hello all. It seems that gcc has trouble with -m32 when structure is passed
> as argument. So I replaced that part by a pointer. Also I made some
> improvements to ufs code to support solaris branch of ufs. I tested it also
> with freebsd and netbsd's branch and it works fine on it too.
> As my 3 FS patches: mtime, FAT and UFS are interdependent I submit a patch
> with all 3 features. If it's really necessary I can split them but it
> requires a lot of unnecessary work


Please don't merge patch, it makes it harder to track down bugs later.

Also, perhaps you should keep datetime.c as it is. I'm planning to
split the normal mode into separate components, it'd be nice if you
don't add files to the normal directory.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]