[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7]: Get cob-webs out of sparc64-ieee1275.rmk
From: |
David Miller |
Subject: |
Re: [PATCH 7/7]: Get cob-webs out of sparc64-ieee1275.rmk |
Date: |
Wed, 04 Mar 2009 03:56:29 -0800 (PST) |
From: Vesa Jääskeläinen <address@hidden>
Date: Wed, 04 Mar 2009 13:50:37 +0200
> David Miller wrote:
> > There is no way anyone tried to build the sparc target in
> > years :-) This updates sparc64-ieee1275.rmk with modern
> > times and regenerates sparc64-ieee1275.mk as well as
> > DISTLIST.
> >
> > 2009-03-03 David S. Miller <address@hidden>
> >
> > * conf/sparc64-ieee1275.rmk: Update.
> > * conf/sparc64-ieee1275.mk: Rebuilt.
> > * DISTLIST: Rebuilt.
>
> There is no need to include .mk files in patches. They just make it a
> bit chaotic.
Ok, I won't include them in the future.
> Please make sure to sync in example normal.mod to be exactly how x86 is.
> This way that is much easier to maintain.
>
> Please compare those to each other and look that they match as much as
> possible. If you see it sensible to differentiate common arch stuff to
> own file like in:
>
> i386-pc.rmk
> i386.rmk
> common.rmk
>
> Then please do so.
I will work on commonization as much as possible as I do more
sparc grub work.
Are you going to apply my patches or do I have to rewrite
everything?