Re: [PATCH] add clear screen command

[phcoder]

Perhaps putting it into normal.mod instead of separate module is a good idea
Felix Zielcke wrote:
> Am Mittwoch, den 08.04.2009, 16:04 -0300 schrieb Carlos Roberto do
> Nascimento Costa:
> > Hello,
> >
> > This simple patch will add a new command to clear the terminal screen. Very
> > useful on the command-line.
>
> Hello,
>
> + *  Copyright (C) 2003,2007  Free Software Foundation, Inc.
> + *  Copyright (C) 2003  NIIBE Yutaka <address@hidden>
>
> This should be just `Copyright (C) 2009  Free Software Foundation, Inc.',
> because it's a new file from this year.
>
> +  (void)mod;                   /* To stop warning. */
> +  cmd = grub_register_command ("clear", grub_cmd_clear,
> +               0, "Clear the terminal screen.");
>
> I think there shouldn't be a `0' but `GRUB_COMMAND_FLAG_CMDLINE'.
> And please write a ChangeLog entry.


--

Regards
Vladimir 'phcoder' Serbinenko