Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.

[Pavel Roskin]

On Sun, 2009-04-12 at 10:19 -0400, Isaac Dupree wrote:
> > -                 grub_ltoa (tmp, c, l);
> > +                 grub_lltoa (tmp, c, l);
> >                 }
> >               else
> >                 {
> >                   n = va_arg (args, int);
> > -                 grub_itoa (tmp, c, n);
> > +                 grub_lltoa (tmp, c, n);
> 
> Do you think they deserve a comment saying why lltoa and that e.g. grub_ltoa 
> would work equally well there except for space reasons?  (In case we ever 
> decided to change that code back, it would be easier to figure out.)

If somebody wants to change the code back, that person would need to
justify adding two functions to kern/misc.c, which is part of the GRUB
core and should be kept minimal.  I don't think it will be easy to
justify.

-- 
Regards,
Pavel Roskin