Re: [PATCH] bug fix for grub-pe2elf

[Bean]

Hi,

ok, committed.

On Tue, Apr 14, 2009 at 11:41 PM, Yoshinori K. Okuji <address@hidden> wrote:
> On Saturday 11 April 2009 21:07:51 Bean wrote:
>> On Sat, Apr 11, 2009 at 6:24 PM, Yoshinori K. Okuji <address@hidden> wrote:
>> > On Saturday 11 April 2009 18:29:00 Bean wrote:
>> >> Hi,
>> >>
>> >> When symbol name is 8 or less, pe store it as short name, which is not
>> >> necessary null-terminated.
>> >
>> > Oh, I didn't know that. Where is it documented?
>>
>> Hi,
>>
>> Recently, I found some wired symbol not found error in modules
>> generated by mingw. After examining the binary image, it seems that PE
>> would use short name even for symbol whose length is 8, therefore no
>> null character at the end. grub-pe2elf assume the name is
>> null-terminated, which could result in extra characters in the
>> symbols.
>
> OK, so you've learned it from experience. :)
> As I don't want to agree on Microsoft's annoying conditions, I don't read the
> official spec, but Wikipedia admits that your interpretation is right.
>
> Regards,
> Okuji
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Bean