[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Code quality
From: |
Robert Millan |
Subject: |
Re: Code quality |
Date: |
Sat, 2 May 2009 13:41:55 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Apr 15, 2009 at 06:10:53PM -0400, Pavel Roskin wrote:
> Hello!
>
> It seems to me that the code quality has decreased in the last weeks.
> In the same time, we have a growing number of compiler warnings. It
> looks like there is a relationship between the two.
>
> I'll appreciate if everybody who recently contributed to GRUB looks at
> the remaining warnings and fixes at least some of them. I don't mean
> hiding the warnings, e.g. adding casts where using different types would
> be more appropriate or initializing variables gcc claims to be
> uninitialized without making sure that gcc is indeed wrong. But if
> there is a good fix, it should be applied.
Can we start using -Werror ? If we can't do it globally, at least for
individual modules. This way we gradually prevent regressions in more
areas, and (hopefully) at some point get rid of them.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
- Re: Code quality,
Robert Millan <=