Re: [PATCH] Use symbol database to maintain module dependence

[Vladimir 'phcoder' Serbinenko]

On Mon, Apr 27, 2009 at 9:58 PM, Bean <address@hidden> wrote:

On Tue, Apr 28, 2009 at 2:13 AM, Vladimir 'phcoder' Serbinenko
<address@hidden> wrote:
> symdb code seems to duplicate your list code. Perhaps you could reuse the
> file from kernel thus making maintaining easier

Hi,

I'm planning to use kern/list.c at first, but there is some issue.
list.c uses grub_strcmp, which means we need to add kern/misc.c as
well. But kern/misc.c uses environment and terminal output, etc. I end
up adding a lot of unrelated stuff just to satisfy the dependence. So
perhaps it'd be better to keep it simple for now.

why not just do
int
grub_strcmp (....)
{
  return strcmp(...);
}
like it's done it other utils?

A better solution is to move the string function to a separate source
file, such as kern/string.c. But this is the subject of another patch.

Also now I'm looking into compiling of grub2 with Apple's gcc and binutils and this patch makes this easier. Was it done in perspective of compiling with Apple's tools? Do you work on this? If you do we could share the effort

-- 
Regards
Vladimir 'phcoder' Serbinenko