Re: [PATCH] support of hfsx ( case comparaison )

[Vladimir 'phcoder' Serbinenko]

On Sun, May 3, 2009 at 7:19 PM, Michael Scherer <address@hidden> wrote:
>
> Le 7 févr. 09 à 22:02, Robert Millan a écrit :
>
>> On Mon, Jan 12, 2009 at 10:52:48PM +0100, Michael Scherer wrote:
>>>
>>> Hi,
>>>
>>> Here is the second patch, for hfsx support. This patch replace the
>>> precedent.
>>>
>>> It is slightly more complex, and I didn't tested it on hfsx as I do
>>> not have a proper partition.
>>> But so far, it detect correctly config file on hfsplus.
>>
>> Hi,
>>
>> Thanks for your contribution.  Would you be willing to assign copyright to
>> the FSF for this?  If you're fine with it, please let the FSF copyright
>> clerk (CCed) know so he can send you the form.
>
>
> Thanks to some postal problems, it took some months to get the copyright
> assignement
> to me. So, now it is over and I think you can apply the patch, I have
>  rediffed against latest svn.
>
> I tried to test it again, just in case, but grub is failling with "menuentry
> , command not found." I will investigate a little
> bit more.
>
Hello, thank you for your contribution
 static int
+grub_hfsplus_is_case_insentive (struct grub_hfsplus_data *data)
+{
You can declare this function as inline. This way you also doesn't
need to temporarily save its result for performance
@@ -218,6 +228,7 @@ struct grub_hfsplus_data
   /* This is the offset into the physical disk for an embedded HFS+
      filesystem (one inside a plain HFS wrapper).  */
   int embedded_offset;
+  int catalog_cmp_key;
Where is this used? I see that you set it to a value but don't see you
actually using it
> Here is a updated patch.
>
>
>
> --
> Michael Scherer
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko