grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] more scripting fixes


From: Pavel Roskin
Subject: Re: [PATCH] more scripting fixes
Date: Fri, 12 Jun 2009 18:10:00 -0400

On Wed, 2009-06-10 at 12:52 +0200, Vladimir 'phcoder' Serbinenko wrote:
> +       Fix handling of string like \"hello\" and "a
> +       b"
> +
> +       * script/sh/lexer.c (check_textstate): accept
> GRUB_PARSER_STATE_ESC
> +       (grub_script_yylex): fix parsing of quoting, escaping and
> newline

I needed to tweak the patch and remove a trivial chunk from it to make
it apply to the current sources.  The adjusted patch is attached.
ChangeLog entries should not be part of the patch.

I confirm that the patch doesn't introduce any compiler warnings.  The
patch does fix what it claims to fix.

But something is still wrong:

grub:sh > echo "a\"b""
a\b
grub:sh > echo "a\"b''c
a\bc

It looks like \" cancels quoting for the subsequent characters, but it
shouldn't.

-- 
Regards,
Pavel Roskin

Attachment: 02-lexer.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]