grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 7/18] Don't clobber ebx/rbx in inline assembly when compilin


From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH 7/18] Don't clobber ebx/rbx in inline assembly when compiling with Apple's CC
Date: Tue, 16 Jun 2009 12:50:59 +0200



On Tue, Jun 16, 2009 at 3:32 AM, Pavel Roskin <address@hidden> wrote:
On Sat, 2009-05-30 at 16:49 +0200, Vladimir 'phcoder' Serbinenko wrote:
> +#ifdef APPLE_CC
>    __asm__ __volatile__ ("xorl %%eax, %%eax\n\t"
> -                        "cpuid":::"%rax", "%rbx", "%rcx", "%rdx");

Why do we need preprocessor conditionals here?  What are we winning?  I
think it's more important to have reusable, well tested and well
maintained code that to save two assembly instructions.
You're right. Just when doing this thing I was concerned to affect generic code as less as possible

--
Regards,
Pavel Roskin


_______________________________________________
Grub-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/grub-devel



--
Regards
Vladimir 'phcoder' Serbinenko

reply via email to

[Prev in Thread] Current Thread [Next in Thread]