[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] File access library for lua

From: Pavel Roskin
Subject: Re: [PATCH] File access library for lua
Date: Sun, 21 Jun 2009 20:42:33 -0400

On Sun, 2009-06-21 at 19:33 +0800, Bean wrote:

> I've added a few function in the lua grub library to access files:
> I also enable the string library from lua.

The patch doesn't introduce any compiler warnings, and that's good.

It makes lua.mod bigger by about 10%, but it's very little compared to
the added functionality.

Please don't add trailing whitespace.  STGit detects it in two places.

There are several cases of missing spaces before parentheses.

We probably need NESTED_FUNC_ATTR in the dir definition in struct
grub_fs, as it takes two arguments.  But is a separate issue.

I'm feeling uneasy about having a parser in GRUB that is not used by
default, but it's not related to the quality of the patch.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]