[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix for loading modules from read-only memory area (Re: clea
From: |
Pavel Roskin |
Subject: |
Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)) |
Date: |
Fri, 26 Jun 2009 18:26:57 -0400 |
On Fri, 2009-06-26 at 19:43 +0200, Robert Millan wrote:
> On Fri, Jun 26, 2009 at 01:16:57PM -0400, Pavel Roskin wrote:
> > > But as for 02-elf-renames.patch we could try to make this more
> > > consistent. In
> > > efiemu I used 'W' (inspired by ElfW() macro in glibc), then in some
> > > places you
> > > use 'K' and in other places 'T'. Can we use the same everywhere? I don't
> > > care which letter, I'm not THAT much into bikeshed :-)
> >
> > "T" stands for "target" and "K" stands for "kernel". Yes, we can use
> > ElfW everywhere. But I would try to avoid any mass renames. It's very
> > easy to write Elf instead of ElfW somewhere in the code, and it would
> > compile, but it won't work.
>
> Ok, I don't mind. Unless you have any objections, I'll merge your two
> patches with mine and commit that.
Please consider following patches. They avoid the massive rename. ELF
header reorganization is split from adding support for modules in ROM.
--
Regards,
Pavel Roskin
01-select-elf.patch
Description: Text Data
02-module-ro.patch
Description: Text Data
- [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), (continued)
- [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/24
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/25
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/25
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/25
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)),
Pavel Roskin <=
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/27
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/28