Re: [Fwd: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1]

[Felix Zielcke]

Am Samstag, den 25.07.2009, 18:45 +0200 schrieb Robert Millan:
> On Sat, Jul 25, 2009 at 01:35:02AM +0200, Felix Zielcke wrote:
> > Is this an acceptable fix?
> > Though I have the feeling this isn't a proper one.
> > 
> > -------- Weitergeleitete Nachricht --------
> > > Von: Bob Gilligan <address@hidden>
> > > Reply-to: Bob Gilligan <address@hidden>, address@hidden
> > > An: address@hidden
> > > Betreff: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1
> > > Datum: Fri, 24 Oct 2008 16:19:59 -0700
> > > 
> > > Package: grub-pc
> > > Version: 1.96+20080724-10
> > > 
> > > After installing grub-pc on an IBM x3250 with two 160 GB drives, with 
> > > the root filesystem configured using mdadm for RAID-1, grub fails to 
> > > boot, printing:
> > > 
> > > Welcome to GRUB!
> > > 
> > > error: unknown device fd1
> > > Entering rescue mode ...
> > > grub rescue>
> 
> ISTR we disabled floppy support completely in debian in order to avoid this
> kind of trouble (I would disable it in official GRUB as well, but I can
> already feel there'd be some opposition :-)).

Only for util/hostdisk.c

> Anyway, my point is that floppies are too unreliable.  We detect them when
> iterating even if they're not readable.  Perhaps we could actually probe them
> for read during iteration to solve this.
> 
> > > +  grub_errno = GRUB_ERR_NONE;  /* Used as error flag */
> > >     device_name = grub_file_get_device_name (name);
> > >     if (grub_errno)
> > >       return 0;
> 
> This looks like a hack.
> 

r2444 should fix this. I just check now if it returns 0 and not for
grub_errno.

-- 
Felix Zielcke
Proud Debian Maintainer