grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'


From: Robert Millan
Subject: Re: [PATCH] Detect key modifier status in 'sleep --interruptible'
Date: Mon, 24 Aug 2009 14:56:41 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Aug 24, 2009 at 10:24:06AM +0100, Colin Watson wrote:
> diff -Nur -x '*.orig' -x '*~' grub2-1.96+20090725/term/ieee1275/ofconsole.c 
> grub2-1.96+20090725.new/term/ieee1275/ofconsole.c
> --- grub2-1.96+20090725/term/ieee1275/ofconsole.c     2009-06-10 
> 22:04:23.000000000 +0100
> +++ grub2-1.96+20090725.new/term/ieee1275/ofconsole.c 2009-08-24 
> 10:17:58.000000000 +0100
> @@ -396,6 +396,8 @@
>      .fini = grub_ofconsole_fini,
>      .checkkey = grub_ofconsole_checkkey,
>      .getkey = grub_ofconsole_getkey,
> +    /* No attempt to support this for Open Firmware yet. */
> +    .keystatus = NULL,
>    };

Btw, I ommitted this from the last patch I sent, as it is unnecessary.  The
BSS is zero'ed before grub_main() so all uninitialized variables are
implicitly 0.  In this kind of structs, when a member is optional and we
don't implement it, we just skip it.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]