Re: [PATCH] Don't try to use help2man when cross-compiling

[Robert Millan]

On Thu, Sep 10, 2009 at 11:51:04PM +0100, Colin Watson wrote:
> On Thu, Sep 10, 2009 at 09:20:19PM +0200, Robert Millan wrote:
> > On Thu, Sep 10, 2009 at 04:37:29PM +0100, Colin Watson wrote:
> > > Index: configure.ac
> > > ===================================================================
> > > --- configure.ac  (revision 2584)
> > > +++ configure.ac  (working copy)
> > > @@ -147,7 +147,9 @@
> > >  
> > >  # These are not a "must".
> > >  AC_PATH_PROG(RUBY, ruby)
> > > -AC_PATH_PROG(HELP2MAN, help2man)
> > > +if test "x$cross_compiling" = xno; then
> > > +  AC_PATH_PROG(HELP2MAN, help2man)
> > > +fi
> > 
> > Autoconf documentation says you can test for $cross_compiling being set to
> > "yes", but is unclear about the variable being defined or not when we're not
> > cross-compiling.
> 
> It's always set during initialisation.
> 
> > Maybe we should test "x$cross_compiling" != xyes instead?
> 
> This is probably a good idea anyway. AC_RUN_IFELSE just checks against
> yes, so I think it's the right thing to do. Furthermore, if we move this
> down to after the compiler checks then we get a more reliable test.
> 
> Revised patch follows, also addressing Felix's comment. Is this better?

Looks fine.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."