Re: [patch] grub incorrectly identifies ext3 as fat

[Felix Zielcke]

Am Freitag, den 30.10.2009, 19:57 +0100 schrieb Robert Millan:
> On Thu, Oct 29, 2009 at 02:58:09PM +0000, Andrew Clausen wrote:
> > Hi all,
> > 
> > grub (both the boot loader, and grub-probe) incorrectly identifies my
> > ext3 partition as containing a fat file system. This means it can't
> > boot without manual tweaking.  The problem is caused by stale fat
> > signatures... this is probably a common problem, as mke2fs often
> > doesn't wipe old signatures.
> > 
> > I wrote a patch.  In order for a file system to be considered
> > detected, dir() must not only succeed, it also must find at least one
> > file or directory. This is pretty effective at ruling out misdetecting
> > a filesystem based on a stale signature that wasn't wiped by mkfs.
> 
> We already had code for this, see:
> 
> 2009-09-05  Robert Millan  <address@hidden>
> 
>         * util/grub-probe.c (probe): Comment out buggy codepath, which  
>         was unexpectedly enabled by Colin Watson's 2009-09-02 fix.  This
>         should be re-enabled after 1.97.

The problem with this (well not the problem why this was reverted) is
that would just abort with an error if grub-probe detects the wrong
filesystem.
Ok would still be better then as currently embeding the wrong fs module
to core.img

-- 
Felix Zielcke
Proud Debian Maintainer and GNU GRUB developer