[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warn_unused_result attribute (Re: mingw32 compile fixes (Re: [GITGRU

From: Felix Zielcke
Subject: Re: warn_unused_result attribute (Re: mingw32 compile fixes (Re: [GITGRUB] New menu interface (implementation)))
Date: Mon, 09 Nov 2009 21:10:33 +0100

Am Montag, den 09.11.2009, 21:04 +0100 schrieb Robert Millan:
> On Tue, Nov 10, 2009 at 12:46:06AM +0800, Bean wrote:
> > Some system such as ubuntu karmic define write using
> > warn_unused_result attribute, which cause a warning when return
> value
> > of write is not used. As grub compile with -Werror, this turn into
> > error, to work around it, use something like this:
> > 
> >  ssize_t tmp = write(bcat, buf, 2048);
> >  (void) tmp;
> Isn't "(void) write (bcat, buf, 2048)" enough? 

Why not just check the return code and print a warning (or maybe even
error) for tmp != 2048?

Felix Zielcke
Proud Debian Maintainer and GNU GRUB developer

reply via email to

[Prev in Thread] Current Thread [Next in Thread]