[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Don't open same disk twice on OpenFirmware.
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] Don't open same disk twice on OpenFirmware. |
Date: |
Fri, 18 Dec 2009 19:48:09 +0100 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20091109) |
David Miller wrote:
> From: David Miller <address@hidden>
> Date: Fri, 18 Dec 2009 10:33:13 -0800 (PST)
>
>
>> From: Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden>
>> Date: Fri, 18 Dec 2009 17:17:13 +0100
>>
>>
>>> Hello, all. According to David Miller sparc's openboot doesn't support
>>> opening same disk twice. So I implemented handle reusage logic. Tested
>>> on imac g3
>>>
>> At a minimum you have to seek to the beginning of the device
>> as that is one of the many side effects of openning the
>> device.
>>
>
> In fact this proves that your idea can't ever work.
> Each openned instance will expect the file offset
> pointer to be at different locations.
>
> You can't share open instances, therefore.
>
> We really just have to make sure GRUB never violates
> this restriction.
>
Actually we don't open files, only disks and we explicitely seek to
desired position. It was so even before my patch.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature