[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grub-probe support for NetBSD

From: Robert Millan
Subject: Re: [PATCH] grub-probe support for NetBSD
Date: Sun, 3 Jan 2010 17:27:34 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Sat, Jan 02, 2010 at 12:35:44PM +0100, Grégoire Sutre wrote:
>> Can you avoid code duplication here?  Something like:
>> #ifdef __NetBSD__
>>   const char *template = "%s/r%s";
>> #else
>>   const char *template = "%s/%s";
>> #endif
> Indeed, it's better.  But we also need a variable for the extra length  
> (3 for NetBSD and 2 otherwise).  I have updated the patch.

I understand;  don't worry about that, GCC is smart and space is cheap in
util/ anyway.


Would you please send patches as attachments?  URLs don't make it easy for


Robert Millan

  "Be the change you want to see in the world" -- Gandhi

reply via email to

[Prev in Thread] Current Thread [Next in Thread]