[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: keyboard layout patches
From: |
Carles Pina i Estany |
Subject: |
Re: keyboard layout patches |
Date: |
Mon, 18 Jan 2010 20:04:35 +0000 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote:
> + grub_util_write_image ("GRUBLAY", 7, fp);
> + grub_util_write_image ((char *) &version, 4, fp);
>
> should be macroified and put somewhere in a header instead of duplicating
I agree. Any reason that I don't see that in util/grub-mkfont.c:
grub_util_write_image ("FILE", 4, file);
grub_util_write_image ("PFF2", 4, file);
and then in font/font.c:
static const char section_names_file[4] = { 'F', 'I', 'L', 'E' };
static const char pff2_magic[4] = { 'P', 'F', 'F', '2' };
?
If should be in a macro (as I think so) I will fix after finishing other
things.
Cheers,
--
Carles Pina i Estany
http://pinux.info
Re: keyboard layout patches,
Carles Pina i Estany <=
Re: keyboard layout patches, Carles Pina i Estany, 2010/01/18