[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [RESEND] GRUB script lexer rewrite using flex
From: |
BVK Chaitanya |
Subject: |
Re: [PATCH] [RESEND] GRUB script lexer rewrite using flex |
Date: |
Mon, 25 Jan 2010 16:12:23 +0530 |
On Mon, Jan 25, 2010 at 1:27 PM, Robert Millan <address@hidden> wrote:
> On Sat, Jan 23, 2010 at 10:39:47AM +0530, BVK Chaitanya wrote:
>> Attached is the updated patch with changes as per review comments (by
>> phcoder). With these changes sh.mod file size is reduced from 38K to
>> 28K :-)
>
> Very nice! But I thought the flex-based rewrite would involve some size
> increase. Has this changed, or I'm missing something?
>
Yes, original non-flex lexer was only 15K. So we still have around
15K increase.
First flex-lexer version resulted in 38K, but after implementing code
review suggestions, it came down to 28K. I guess the reason might be
because I replaced some macros with functions.
--
bvk.chaitanya